chore: swallow TargetClosedErrors in beforeunload dialog.dismiss()#39788
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Mar 25, 2026
Merged
chore: swallow TargetClosedErrors in beforeunload dialog.dismiss()#39788dgozman merged 1 commit intomicrosoft:mainfrom
dgozman merged 1 commit intomicrosoft:mainfrom
Conversation
hbenl
force-pushed
the
dialog-dismiss-target-closed
branch
from
0554def to
5450e51
Compare
hbenl
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| try { | ||
| await this._channel.dismiss(); | ||
| } catch (e) { | ||
| if (isTargetClosedError(e) && this.type() === 'beforeunload') |
Collaborator
Author
There was a problem hiding this comment.
Because this test expects dialog.dismiss() to throw for an alert dialog if it was called after page.close().
Collaborator
There was a problem hiding this comment.
Let's remove this test, we think it is accidental, and allow safely dismissing any dialog.
hbenl
force-pushed
the
dialog-dismiss-target-closed
branch
from
5450e51 to
0ff7d51
Compare
Contributor
Test results for "tests 1"2 failed 7 flaky38897 passed, 845 skipped Merge workflow run. |
Contributor
Test results for "MCP"5523 passed, 340 skipped Merge workflow run. |
dgozman
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #39701 (comment).
This swallows TargetClosedErrors only forbeforeunloaddialogs because this test checks thatdialog.dismiss()will throw for alert dialogs.